Skip to content

Clean Code for terminal/bundles/org.eclipse.terminal.control#2731

Merged
akurtakov merged 2 commits into
masterfrom
clean-code/terminal/bundles/org.eclipse.terminal.control
Jun 8, 2026
Merged

Clean Code for terminal/bundles/org.eclipse.terminal.control#2731
akurtakov merged 2 commits into
masterfrom
clean-code/terminal/bundles/org.eclipse.terminal.control

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

@eclipse-platform-bot eclipse-platform-bot commented Jun 6, 2026

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Jun 6, 2026 •
edited
Loading

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

terminal/bundles/org.eclipse.terminal.control/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 5a81df6646ed6df934f2bfed7351833f10243e34 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 8 Jun 2026 07:43:04 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/terminal/bundles/org.eclipse.terminal.control/META-INF/MANIFEST.MF b/terminal/bundles/org.eclipse.terminal.control/META-INF/MANIFEST.MF
index f650b6a9c8..e22f4815dc 100644
--- a/terminal/bundles/org.eclipse.terminal.control/META-INF/MANIFEST.MF
+++ b/terminal/bundles/org.eclipse.terminal.control/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.terminal.control; singleton:=true
-Bundle-Version: 1.1.100.qualifier
+Bundle-Version: 1.1.200.qualifier
 Bundle-Activator: org.eclipse.terminal.internal.control.impl.TerminalPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026 •
edited
Loading

Test Results

    54 files  ±0      54 suites  ±0   57m 28s ⏱️ + 5m 5s
 4 671 tests ±0   4 649 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 907 runs  ±0  11 754 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit 9dd36a9. ± Comparison against base commit bd58498.

♻️ This comment has been updated with latest results.

@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/terminal/bundles/org.eclipse.terminal.control branch from f9bc7fd to 1e964fe Compare June 8, 2026 07:36
@akurtakov akurtakov merged commit 1223f47 into master Jun 8, 2026
18 checks passed
@akurtakov akurtakov deleted the clean-code/terminal/bundles/org.eclipse.terminal.control branch June 8, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eclipse-platform-bot @akurtakov